-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11713 FN constParameterPointer/Reference with unused parameter #6085
Conversation
I wonder how much noise this will cause.
|
I also classify that as a false positive. I would prefer that we fix such FPs... if there are ifdefs and stuff in the scope that could hide code then do not warn. However I would suggest that the "possible FP" warnings are still reported in such cases with a separate ID (maybe enabled by --inconclusive). |
I do not agree. IMO that is the point of analyzing multiple configurations. int f() {
int i; // unassigned
#ifdef MACRO
i = 0;
#endif
return i; // uninitialized
} In that case we correctly detect the unassigned variable and the uninitialized one. Not reporting it in the case this PR addresses would be inconsistent and thus unexpected. |
No description provided.